Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸžFix ollama #2519

Merged
merged 6 commits into from
Jan 20, 2025
Merged

๐ŸžFix ollama #2519

merged 6 commits into from
Jan 20, 2025

Conversation

ashwinvaidya17
Copy link
Collaborator

๐Ÿ“ Description

โœจ Changes

Select what type of change your PR is:

  • ๐Ÿž Bug fix (non-breaking change which fixes an issue)
  • ๐Ÿ”จ Refactor (non-breaking change which refactors the code base)
  • ๐Ÿš€ New feature (non-breaking change which adds functionality)
  • ๐Ÿ’ฅ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ๐Ÿ“š Documentation update
  • ๐Ÿ”’ Security update

โœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • ๐Ÿ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • ๐Ÿ“š I have made the necessary updates to the documentation (if applicable).
  • ๐Ÿงช I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (084331d) to head (82748d8).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...rc/anomalib/models/image/vlm_ad/backends/ollama.py 33.33% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   78.94%   79.02%   +0.07%     
==========================================
  Files         311      311              
  Lines       13197    13182      -15     
==========================================
- Hits        10419    10417       -2     
+ Misses       2778     2765      -13     
Flag Coverage ฮ”
integration_py3.10 63.57% <33.33%> (?)
unit_py3.10 64.60% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@ashwinvaidya17 ashwinvaidya17 added this pull request to the merge queue Jan 20, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 20, 2025
Fix ollama

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@ashwinvaidya17 ashwinvaidya17 removed this pull request from the merge queue due to a manual request Jan 20, 2025
@ashwinvaidya17 ashwinvaidya17 added this pull request to the merge queue Jan 20, 2025
@samet-akcay samet-akcay removed this pull request from the merge queue due to the queue being cleared Jan 20, 2025
@samet-akcay samet-akcay merged commit 088882f into main Jan 20, 2025
13 of 14 checks passed
@samet-akcay samet-akcay deleted the ashwin/fix_ollama branch January 20, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cannot import name '_encode_image' from 'ollama._client'
2 participants