Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When using synthetic validation and test splits, the visualizer is broken.
This is because the path fort he synthetically generated anomalous samples is
anomalib/src/anomalib/data/utils/synthetic.py
Line 44 in 9a0c755
The visualizes generates output file names by looking up the dataset name in this path but cannot find it and terminates before saving the visualizer images.
anomalib/src/anomalib/utils/path.py
Line 320 in 9a0c755
To overcome this the dataset name is added o the temporary dir.
Also this error was obscured by wrong exception handling:
anomalib/src/anomalib/utils/path.py
Lines 319 to 323 in 9a0c755
will not catch the error because it is a StopIteration type error and not an ValueError.
The right task type for synthetic dataset needs to be set manually and cannot be used from the folder dataset
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.