-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 v2 - Refactor: Add missing auxiliary attributes to AnomalibModule
#2460
Merged
samet-akcay
merged 10 commits into
openvinotoolkit:release/v2.0.0
from
samet-akcay:add-missing-aux-components
Dec 11, 2024
Merged
🔨 v2 - Refactor: Add missing auxiliary attributes to AnomalibModule
#2460
samet-akcay
merged 10 commits into
openvinotoolkit:release/v2.0.0
from
samet-akcay:add-missing-aux-components
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
…lly include available callbacks (pre-processor, post-processor, evaluator, visualizer) based on their existence. Update docstring for clarity on return values.
…or and metrics callbacks. Simplify callback configuration to streamline the process and enhance maintainability.
samet-akcay
changed the title
Add missing auxil
🔨 v2 - Refactor: Add missing auxiliary attributes to Dec 9, 2024
AnomalibModule
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
ashwinvaidya17
approved these changes
Dec 9, 2024
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2.0.0 #2460 +/- ##
=================================================
Coverage ? 78.41%
=================================================
Files ? 303
Lines ? 12974
Branches ? 0
=================================================
Hits ? 10173
Misses ? 2801
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…into add-missing-aux-components
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request introduces enhancements to the
AnomalibModule
andEngine
classes within the Anomalib library. The changes standardize the component configuration pattern across pre-processors, post-processors, evaluators, and visualizers, with a particular focus on refactoring the post-processor implementation.✨ Changes
Post-Processor Refactoring:
_resolve_post_processor
method to standardize post-processor configurationconfigure_post_processor
classmethod to provide default post-processor setupComponent Configuration Pattern:
configure_callbacks
to handle all components uniformlyTrue
: Use default configurationFalse
: Disable the componentDocumentation and Type Hints:
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.