-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set devices to 1 if multi-gpu is configured #2256
Set devices to 1 if multi-gpu is configured #2256
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 80.80% 80.64% -0.17%
==========================================
Files 248 248
Lines 10859 10894 +35
==========================================
+ Hits 8775 8785 +10
- Misses 2084 2109 +25 ☔ View full report in Codecov by Sentry. |
src/anomalib/engine/engine.py
Outdated
# TODO(ashwinvaidya17, djdameln, samet-akcay): Add Multi-GPU support to Anomalib | ||
# https://github.com/openvinotoolkit/anomalib/issues/1449 | ||
devices = self._cache.args.get("devices") | ||
if devices and str(devices).count(","): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if someone passes devices =2
? If I am not wrong, it will still start distributed training.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I've added few more logic to cover some other edge cases.
Closing as this for the sake of #2435 |
📝 Description
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.