assign test split for folder dataset #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
requested changes
Apr 12, 2022
There was a problem hiding this comment.
Thanks for adding this @alexriedel1! It would also be great to cover normal_dir in the tests, but I guess we might need some refactoring in the tests to do so. We could potentially address this in a separate PR.
|
Thanks @alexriedel1, just in time! We're planning to release v0.2.6 today and upload to pypi. This will be a nice addition! |
samet-akcay
approved these changes
Apr 12, 2022
samet-akcay
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #180 (comment)
If you provide a
config.dataset.normal_testto the datamodule, you can now define test data in a folder datamodule.