Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Export docstring in CLI #2058

Merged

Conversation

ashwinvaidya17
Copy link
Collaborator

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just a single question

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
@ashwinvaidya17
Copy link
Collaborator Author

Might create conflict with #1767

ashwinvaidya17 and others added 4 commits May 15, 2024 09:29
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@ashwinvaidya17 ashwinvaidya17 enabled auto-merge (squash) May 15, 2024 07:41
@ashwinvaidya17 ashwinvaidya17 disabled auto-merge May 15, 2024 07:45
@ashwinvaidya17 ashwinvaidya17 enabled auto-merge (squash) May 15, 2024 07:46
@ashwinvaidya17 ashwinvaidya17 disabled auto-merge May 15, 2024 07:46
@ashwinvaidya17 ashwinvaidya17 enabled auto-merge (squash) May 15, 2024 07:47
@ashwinvaidya17 ashwinvaidya17 merged commit 395c5f6 into openvinotoolkit:main May 15, 2024
7 checks passed
@ashwinvaidya17 ashwinvaidya17 deleted the refactor/export_doc branch May 15, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 export subcommand of the CLI does not have a good documentation.
2 participants