Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed keys in data configs to fit AnomalibDataModule parameters #2032

Merged

Conversation

abc-125
Copy link
Contributor

@abc-125 abc-125 commented Apr 28, 2024

📝 Description

There is a mismatch between some data config keys and AnomalibDataModule init parameters for all datasets.
It looks like normalization and center_crop were replaced by more general transform, transform_config_train and transform_config_eval were renamed to train_transform and eval_transform, respectively.

I changed this in all data config files, now it is possible to start the training using these configs.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: abc-125 <63813435+abc-125@users.noreply.github.com>
@abc-125 abc-125 requested a review from samet-akcay as a code owner April 28, 2024 15:25
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing this

@samet-akcay samet-akcay merged commit 81cd4c5 into openvinotoolkit:main Apr 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong keys in data configs
2 participants