Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SaveToCSVCallback with PL CSVLogger #198

Merged
merged 7 commits into from
Apr 5, 2022
Merged

Replace SaveToCSVCallback with PL CSVLogger #198

merged 7 commits into from
Apr 5, 2022

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Apr 5, 2022 •
edited
Loading

Description

  • Current SaveToCSVCallback only saves image path, true and predicted labels to a csv file. It is also not up-to-date with the new performance reporting mechanism. As discussed, it's being replaced with the PL CSVLogger.

  • Fixes Padim object has not attribute 'results' #184

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

ashwinvaidya17
ashwinvaidya17 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

djdameln
djdameln approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit c8ef5dd into development Apr 5, 2022
@samet-akcay samet-akcay deleted the fix/sa/replace-csv-logger branch April 5, 2022 15:51
@samet-akcay samet-akcay linked an issue Apr 5, 2022 that may be closed by this pull request
Switch to CSV Logger #16
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Padim object has not attribute 'results' Switch to CSV Logger
3 participants
@samet-akcay @ashwinvaidya17 @djdameln