Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: fix image transform to float #1902

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Add: fix image transform to float #1902

merged 8 commits into from
Mar 26, 2024

Conversation

Bepitic
Copy link
Contributor

@Bepitic Bepitic commented Mar 24, 2024

📝 Description

✨ Changes

Select what type of change your PR is:

  • [X ] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@Bepitic Bepitic requested a review from djdameln as a code owner March 24, 2024 20:40
@Bepitic Bepitic force-pushed the Fix-Video-Get-item-from-indexer-image-unit8 branch from 131a940 to dabd0ff Compare March 24, 2024 21:30
AlexanderDokuchaev and others added 3 commits March 25, 2024 11:13
@AlexanderDokuchaev @samet-akcay
📚 Add action to check broken links (openvinotoolkit#1838)
7edb6af 
* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
@TurboJonte @samet-akcay
Use LabelName ENUM for label assignment (openvinotoolkit#1881)
8ebfdf5 
* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
@TurboJonte @samet-akcay
Changed prediction label assignment for OpenVINO inferencer (openvino…
6be4c80 
…toolkit#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>
djdameln
djdameln requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for finding and addressing this bug. This must've slipped through the v1 testing. I have one comment concerning the scaling of the input tensors, see below.

Bepitic added 2 commits March 25, 2024 18:58
@Bepitic
Add: fix image transform to float
5588d3f 
Signed-off-by: Bepitic <bepitic@gmail.com>
@Bepitic
upd: video dtpe transform from torchvision
7be9ec3 
Signed-off-by: Bepitic <bepitic@gmail.com>
@Bepitic Bepitic force-pushed the Fix-Video-Get-item-from-indexer-image-unit8 branch from a76e7f3 to 7be9ec3 Compare March 25, 2024 17:58
@Bepitic Bepitic requested a review from djdameln March 25, 2024 18:11
@samet-akcay @djdameln
Update src/anomalib/data/base/video.py
f79181a 
Co-authored-by: Dick Ameln <amelndjd@gmail.com>
@Bepitic
Copy link
Contributor Author

Bepitic commented Mar 26, 2024

Thank you so fast, 👍

djdameln
djdameln approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

@djdameln djdameln mentioned this pull request Mar 26, 2024
Merged
9 tasks
@djdameln djdameln changed the base branch from main to release/1.0.1 March 26, 2024 10:10
@samet-akcay samet-akcay merged commit 9b78034 into openvinotoolkit:release/1.0.1 Mar 26, 2024
8 checks passed
samet-akcay added a commit that referenced this pull request Mar 27, 2024
@samet-akcay @djdameln
@AlexanderDokuchaev @TurboJonte @Bepitic @ashwinvaidya17
Merge v1.0.1 to main (#1905)
e35b574 
* Update CHANGELOG.md (#1899)

* Update __init__.py

* Fix metric bug (#1900)

* check metrics by name instead of key

* remove prefix from temp metric collection

* 🔒 Bump onnx version as the previous version caused security issues (#1907)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Bump onnx version as the previous version caused security issues

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>

* Add: fix image transform to float (#1902)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Add: fix image transform to float

Signed-off-by: Bepitic <bepitic@gmail.com>

* upd: video dtpe transform from torchvision

Signed-off-by: Bepitic <bepitic@gmail.com>

* Added the scale.

Signed-off-by: Bepitic <bepitic@gmail.com>

* Update src/anomalib/data/base/video.py

Co-authored-by: Dick Ameln <amelndjd@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>

* Fix video bug and add tests (#1910)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* squeeze temporal dimension when clip length is 1

* add unit test for video input tensor dtype

* add test for single frame clips

* update changelog

* add author

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Temporarily set devices to 1

* 🐞 Add greyscale conversion (#1911)

Add greyscale conversion

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* 🐞 Fix publish workflow (#1912)

Disable tty prompt for gpg import

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Paco <bepitic@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>
Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@samet-akcay samet-akcay samet-akcay approved these changes

@djdameln djdameln djdameln approved these changes

@yunchu yunchu Awaiting requested review from yunchu

@paularamo paularamo Awaiting requested review from paularamo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: anomalib video not working on Datasets (Avenue, UCSDped)
6 participants
@Bepitic @ashwinvaidya17 @samet-akcay @djdameln @AlexanderDokuchaev @TurboJonte