-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ Upgrade TorchMetrics #1879
β¨ Upgrade TorchMetrics #1879
Conversation
* temporarily enable tests on hotfix branches Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * temporarily enable tests on hotfix branches Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
* Migrate to custom precision recall curve Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * upgrade torchmetrics Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Remove check Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix CLI Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix PRO computation Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix typo Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Skip normalization tests Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
==========================================
- Coverage 81.03% 80.99% -0.05%
==========================================
Files 222 224 +2
Lines 10163 10195 +32
==========================================
+ Hits 8236 8257 +21
- Misses 1927 1938 +11 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this long awaited fix. I only have a single comment.
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a ton!
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
π Description
β¨ Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.