Update for nncf_task #145
Merged
Update for nncf_task #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9c44f3 to
5995978
Compare
5995978 to
79edc56
Compare
646dc61 to
1e2267a
Compare
samet-akcay
requested changes
Mar 16, 2022
There was a problem hiding this comment.
@AlexanderDokuchaev, Thank you for making this PR. I have few comments and opens that I left in the code.
anomalib/integration/__init__.py
Outdated
Comment on lines
1
to
15
| """Integration.""" | ||
|
|
||
| # Copyright (C) 2021 Intel Corporation | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions | ||
| # and limitations under the License. |
There was a problem hiding this comment.
Rather than creating anomalib/integration, we could place nncf_callback and utils.py into anomalib/utils/callbacks/nncf. In this case, the existing flow would be kept as is. More specifically, the structure of anomailb/utils/callbackwould be something like the following:
.
├── __init__.py
├── callbacks
│ ├── __init__.py
│ ├── cdf_normalization.py
│ ├── compress.py
│ ├── min_max_normalization.py
│ ├── model_loader.py
│ ├── nncf
│ │ ├── __init__.py
│ │ ├── nncf_callback.py
│ │ └── utils.py
│ ├── save_to_csv.py
│ ├── tiler.py
│ ├── timer.py
│ └── visualizer_callback.py
There was a problem hiding this comment.
I agree. Let's stick to the existing structure and place the nncf files under callbacks.
djdameln
approved these changes
Mar 22, 2022
samet-akcay
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework nncf integration to use in OTE:
compressiontoopenvinoin config andCompressModelCallbacktoOpenVINOCalbackbecause model_optimizer does not compress model and it can confuse users.