Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu-24.04-arm to the testing #54

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 21, 2025

+          - os: ubuntu-24.04-arm
+            node-version: 22.x
+            status: 'current'

Standard GitHub-hosted runners for public repositories

cclauss and others added 2 commits January 21, 2025 11:59
```diff
+          - os: ubuntu-24.04-arm
+            node-version: 22.x
+            status: 'current'
```
@missinglink
Copy link
Contributor

Libpostal requires an additional configure flag to build on ARM which I've added in 2e0c2dd

Cheers 🍻

@missinglink missinglink merged commit da73c7c into openvenues:master Jan 22, 2025
10 checks passed
@missinglink
Copy link
Contributor

I'm not convinced the --disable-sse2 flag is needed since they don't use it in the libpostal repo and they test on macos-latest which is an ARM runner 🤷

@cclauss cclauss deleted the patch-1 branch January 22, 2025 12:30
@cclauss
Copy link
Contributor Author

cclauss commented Jan 22, 2025

@missinglink
Copy link
Contributor

missinglink commented Jan 22, 2025

Is there a reason for this beta version still?!?

No it's just old

@missinglink
Copy link
Contributor

If you're going to do another PR can you also please remove this || cat config.log thing, I don't recall why it's there, presumably any output would already be on stderr 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants