-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH Actions versions #4542
Update GH Actions versions #4542
Conversation
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
Codecov ReportBase: 59.89% // Head: 60.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #4542 +/- ##
=============================================
+ Coverage 59.89% 60.18% +0.28%
- Complexity 11925 12087 +162
=============================================
Files 1557 1570 +13
Lines 62400 62661 +261
Branches 6982 7020 +38
=============================================
+ Hits 37375 37711 +336
+ Misses 22868 22775 -93
- Partials 2157 2175 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8a8d957
to
83f93c2
Compare
Have you validated that the cache works? At least in the latest run, it says "maven cache is not found". I think within the scope of the pr, the actions have run more than once. Shouldn't there be cache in that case? |
Or was it that the cache was only within the scope of one actions run? I see in a later step that cache is saved but at that point, it's no longer needed for anything within the actions run. |
I'm rerunning CI as I'm not sure. |
To me it looks like the cache is retrieved during jdk setup and correctly used by the maven command. Can you confirm this? |
Yes it looks like it used it now. I wonder why it didn't use it before. Did the last commit before this somehow affect maven? |
No, but the cache is cleared after a few days. I think this is what happened here. |
Github Actions is updating their node runtime version, so you see a large number of warnings to update to Actions version. Example: https://github.com/opentripplanner/OpenTripPlanner/actions/runs/3313424495
This PR updates the Actions that will stop working in the future.