Use a String for the reference type

opentracing · Jul 15, 2016 · 0e5a342 · 0e5a342
1 parent ff2d9ff
commit 0e5a342
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/opentracing-api/src/main/java/io/opentracing/Tracer.java b/opentracing-api/src/main/java/io/opentracing/Tracer.java
@@ -92,7 +92,7 @@ interface SpanBuilder {
        *
        * @see io.opentracing.References
        */
-      SpanBuilder addReference(Object referenceType, SpanContext referencedContext);
+      SpanBuilder addReference(String referenceType, SpanContext referencedContext);
 
       /** Same as {@link Span#setTag(String, String)}, but for the span being built. */
       SpanBuilder withTag(String key, String value);

diff --git a/opentracing-impl-java8/src/main/java/io/opentracing/propagation/AbstractSpanBuilder.java b/opentracing-impl-java8/src/main/java/io/opentracing/propagation/AbstractSpanBuilder.java
@@ -41,7 +41,7 @@ abstract class AbstractSpanBuilder implements Tracer.SpanBuilder {
     protected abstract AbstractSpan createSpan();
 
     @Override
-    public final Tracer.SpanBuilder addReference(Object referenceType, SpanContext referredTo) {
+    public final Tracer.SpanBuilder addReference(String referenceType, SpanContext referredTo) {
         this.references.add(new Reference(referenceType, referredTo));
         return this;
     }
@@ -88,10 +88,10 @@ public final Span start() {
     }
 
     public static final class Reference {
-        private Object referenceType;
+        private String referenceType;
         private SpanContext referredTo;
 
-        Reference(Object type, SpanContext referredTo) {
+        Reference(String type, SpanContext referredTo) {
             this.referenceType = type;
             this.referredTo = referredTo;
         }

diff --git a/opentracing-impl/src/main/java/io/opentracing/NoopSpanBuilder.java b/opentracing-impl/src/main/java/io/opentracing/NoopSpanBuilder.java
@@ -19,7 +19,7 @@ final class NoopSpanBuilder implements Tracer.SpanBuilder {
     private NoopSpanBuilder() {}
 
     @Override
-    public Tracer.SpanBuilder addReference(Object refType, SpanContext referenced) {
+    public Tracer.SpanBuilder addReference(String refType, SpanContext referenced) {
         return this;
     }