Initial pr #1
Initial pr #1
Conversation
…g), leaving almost only interfaces in OpenTracing.
|
nit (while looking at the file list): is NuGet.exe meant to be a part of the PR? |
| void Finish(); | ||
| void FinishWithOptions(DateTime finishTime); | ||
|
|
||
| void SetBaggageItem(string restrictedKey, string value); |
There was a problem hiding this comment.
unlike SetTag and Log, SetBaggageItem is meant to be paired with a GetBaggageItem...
also, I am fairly confident we are going to remove restrictions on the keys.
There was a problem hiding this comment.
My thought to get the baggage was to do something like this.
var memoryCarrier = new MemoryTextMapCarrier(new Dictionary<string, string>() { });
tracer.Inject(span, memoryCarrier);
var value = memoryCarrier.TextMap[key]But I agree, a GetBaggage(key, value) method on the span is more convinient. I will add it.
There was a problem hiding this comment.
Thanks...
Also, a general point of order: I was inspired by your SpanContext stuff and am attempting to find a compromise where other languages can incorporate a context concept at the OpenTracing API layer without introducing tons of new terminology and cognitive load for the user. I will keep you informed of the RFC PR on that front which I hope to send out this weekend. (I've done the interesting part but need to clean things up)
|
About the nuget.exe. I'm looking at other OSS projects and sometimes I found it included. It is the artifact package builder. I change and exclude it for now and need to look up the best practice for this. |
|
@dawallin: somewhat related to the context stuff, see https://gitter.im/opentracing/public?at=575c92732eaa837d71e8a0fd |
|
closed, because we merged #2 |
Here is the first pull request so we can get something to discuss around.