This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Add mocktracer library. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyleke
suggested changes
Jan 8, 2018
|
@yurishkuro, @isaachier -- are you guys ok with this PR? It doesn't make any changes to the actual API. |
isaachier
approved these changes
Jan 11, 2018
| install(TARGETS opentracing_mocktracer EXPORT OpenTracingTargets | ||
| LIBRARY DESTINATION lib | ||
| ARCHIVE DESTINATION lib) | ||
| endif(BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
Not asking you to change this, just an FYI, the CMake docs seem to be wrong about this point. The expression need not/should not be included in endif arguments. None of the CMake modules follow that pattern.
| include(CTest) | ||
| if(BUILD_TESTING) | ||
| add_subdirectory(test) | ||
| endif() |
There was a problem hiding this comment.
Overall, great work on the CMake stuff :). Very few projects get this right.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mocktracer library similar in design to that included in the other OpenTracing language bindings (for example, Go). It will make it easier for users to test their instrumentation code.
Additionally, I switched all the testing code to use catch2 since it was outgrowing the existing testing framework.