Add support for grpc propagation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, looks good. Thank you. |
cc72bab to
4a7a00a
Compare
|
@rnburn I added a case to test the opentracing_grpc_propagate_context directive. Let me know if this is adequate. |
rnburn
reviewed
Nov 18, 2018
7abbd49 to
df189d8
Compare
|
👍 |
|
@rnburn When should I be expecting the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Adds the
opentracing_grpc_propagate_contextdirective.I extended the pattern laid out by
opentracing_propagate_contextandopentracing_fastcgi_propagate_contextto createopentracing_grpc_propagate_context.Still needs tests, but let me know if I am on the wrong track here.