Support for Nginx 1.24.0 #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested changes
May 8, 2023
There was a problem hiding this comment.
Hi @alekhrycaiko thanks for the PR!
I'd like to keep the version of nginx in Dockerfile-test to the mainline versions. So just adding to the list of versions in ci/build_module_binaries.sh should be enough.
I know it's a little bit confusing, but nginx 1.24.0 is the same as 1.23.4, they're just two different "channels", stable and mainline. All the versions and development happens in mainline.
e38136d to
b383f15
Compare
lucacome
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds 1.24.0
#420