Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to modern versions to get example working #339

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

ebachle
Copy link
Contributor

@ebachle ebachle commented Oct 9, 2022

  • The Composer version has changed, so the hash is no longer correct and it errors out on the build.
  • Lacking the PHP zip extension, composer doesn't install other packages cleanly
  • Moving to modern versions of the jaeger tracing library and opentracing implementation cleans up another error in the example

@miry miry merged commit dbfb5ed into opentracing-contrib:master Oct 9, 2022
@miry
Copy link
Collaborator

miry commented Oct 9, 2022

Thank you @ebachle for the contribution! 🎉

@lucacome lucacome added the chore label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants