Clean up build argument list and add note on lightstep tracer #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LIGHTSTEP_VERSION and ZIPKIN_CPP_VERSION build arguments were removed in https://github.com/opentracing-contrib/nginx-opentracing/pull/155/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L6-L7. The NGINX_OPENTRACING_VERSION build argument was removed in https://github.com/opentracing-contrib/nginx-opentracing/pull/37/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L10. This pr cleans up the list of build arguments available for use. Worth noting: it looks like [Zipkin now supports OpenTracing 1.6.0](https://github.com/rnburn/zipkin-cpp-opentracing/blob/master/ci/build_plugin.sh#L12). Maybe we should add the Zipkin tracer back in to the docker image?
miry
approved these changes
May 14, 2022
It would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LIGHTSTEP_VERSION and ZIPKIN_CPP_VERSION build arguments were removed in https://github.com/opentracing-contrib/nginx-opentracing/pull/155/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L6-L7. The NGINX_OPENTRACING_VERSION build argument was removed in https://github.com/opentracing-contrib/nginx-opentracing/pull/37/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L10. This pr cleans up the list of build arguments available for use.
Worth noting: it looks like Zipkin now supports OpenTracing 1.6.0. Maybe we should add the Zipkin tracer back in to the docker image?