Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Dockerfile to multi-stage build #187

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Convert Dockerfile to multi-stage build #187

merged 1 commit into from
Sep 1, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 31, 2021 •
edited
Loading

  • Use multi-stage build to improve caching and avoid building if the version hasn't changed for a specific library
  • Reduce size of final image
  • Added specific version of NGINX that can be updated automatically with dependabot when a new version comes out

@lucacome
Copy link
Member Author

lucacome commented Aug 31, 2021 •
edited
Loading

I think it triggered a build in my CircleCI 🤔

@miry
Copy link
Collaborator

miry commented Aug 31, 2021

Docker cache layer is for paid plans.

miry
miry reviewed Aug 31, 2021
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@lucacome lucacome force-pushed the dockerfile-multi-stage branch from 8bccf53 to 588b051 Compare August 31, 2021 15:28
@miry
Copy link
Collaborator

miry commented Sep 1, 2021

@lucacome Let me if it is ready?

@lucacome
Copy link
Member Author

lucacome commented Sep 1, 2021

@miry yep it’s ready 🚀

miry
miry reviewed Sep 1, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@miry
Copy link
Collaborator

miry commented Sep 1, 2021

@lucacome It is only double space issue. I can merge it after.

@lucacome lucacome force-pushed the dockerfile-multi-stage branch from 588b051 to 480f937 Compare September 1, 2021 16:09
@lucacome
Copy link
Member Author

lucacome commented Sep 1, 2021

Fixed it, weird that VS Code didn't pick it up 😕

@miry miry merged commit c2da400 into opentracing-contrib:master Sep 1, 2021
@miry
Copy link
Collaborator

miry commented Sep 1, 2021

Nice job. Thank you.

@lucacome lucacome deleted the dockerfile-multi-stage branch September 1, 2021 16:25
@lucacome lucacome added the chore label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aartiukh aartiukh aartiukh left review comments

@miry miry miry approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @miry @aartiukh