-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add package of opentiny/tiny-engine-theme-base #624
feat: add package of opentiny/tiny-engine-theme-base #624
Conversation
WalkthroughThis update introduces a new theme system for the project, including base styling within the Changes
Sequence Diagram(s)N/A Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (13)
- packages/build/vite-config/src/vite-plugins/devAliasPlugin.js (1 hunks)
- packages/design-core/package.json (1 hunks)
- packages/design-core/src/init.js (2 hunks)
- packages/layout/src/DesignSettings.vue (1 hunks)
- packages/plugins/bridge/src/Main.vue (1 hunks)
- packages/plugins/materials/src/meta/layout/src/Main.vue (1 hunks)
- packages/settings/panel/src/Main.vue (1 hunks)
- packages/theme/base/package.json (1 hunks)
- packages/theme/base/src/base.js (1 hunks)
- packages/theme/base/src/dark-component.js (1 hunks)
- packages/theme/base/src/index.js (1 hunks)
- packages/theme/base/src/light-component.js (1 hunks)
- packages/theme/base/vite.config.js (1 hunks)
Files skipped from review due to trivial changes (8)
- packages/build/vite-config/src/vite-plugins/devAliasPlugin.js
- packages/design-core/package.json
- packages/layout/src/DesignSettings.vue
- packages/plugins/bridge/src/Main.vue
- packages/plugins/materials/src/meta/layout/src/Main.vue
- packages/settings/panel/src/Main.vue
- packages/theme/base/package.json
- packages/theme/base/vite.config.js
Additional comments not posted (9)
packages/theme/base/src/index.js (3)
1-1
: Import statement looks good.The import statement correctly imports the necessary theme components from
base.js
.
3-8
: LGTM! Ensure consistency in theme naming conventions.The
tinyEngineThemeLight
object is well-structured and follows a consistent naming convention. Verify that theid
,name
, andcnName
fields align with the project's standards.
10-15
: LGTM! Ensure consistency in theme naming conventions.The
tinyEngineThemeDark
object is well-structured and follows a consistent naming convention. Verify that theid
,name
, andcnName
fields align with the project's standards.packages/theme/base/src/light-component.js (1)
1-19
: LGTM! Ensure all necessary theme properties are included.The
concatThemeLight
object is well-structured and includes various theme properties for light mode. Verify that all necessary properties are included and correctly defined.packages/theme/base/src/dark-component.js (1)
1-19
: LGTM! Ensure all necessary theme properties are included.The
concatThemeDark
object is well-structured and includes various theme properties for dark mode. Verify that all necessary properties are included and correctly defined.packages/design-core/src/init.js (2)
20-20
: Import statement looks good.The import statement correctly imports the
tinyEngineThemeLight
from@opentiny/tiny-engine-theme-base
.
55-55
: LGTM! Ensure proper initialization of the theme.The theme initialization with
TinyThemeTool
andtinyEngineThemeLight
is well-structured. Verify that the initialization aligns with the project's standards.packages/theme/base/src/base.js (2)
1-297
: LGTM! Ensure all necessary base theme properties are included.The
tinyBaseTheme
object is well-structured and includes various base theme properties. Verify that all necessary properties are included and correctly defined.
299-301
: Export statements look good.The export statements correctly export the light and dark components.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
@opentiny/tiny-engine-theme-base
, providing a comprehensive base theme with light and dark variations.Enhancements
design-core
to use the newtinyEngineThemeLight
theme.Style
Dependencies
@opentiny/tiny-engine-theme-base
as a dependency indesign-core
.