-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): update registry #578
Conversation
WalkthroughThe recent changes across several packages involve a consistent renaming effort where the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (36)
- packages/design-core/src/layout/DesignPlugins.vue (1 hunks)
- packages/design-core/src/layout/DesignSettings.vue (1 hunks)
- packages/design-core/src/layout/DesignToolbars.vue (1 hunks)
- packages/entry/docs/registry.md (1 hunks)
- packages/plugins/block/index.js (1 hunks)
- packages/plugins/bridge/index.js (1 hunks)
- packages/plugins/data/index.js (1 hunks)
- packages/plugins/datasource/index.js (1 hunks)
- packages/plugins/i18n/index.js (1 hunks)
- packages/plugins/materials/index.js (1 hunks)
- packages/plugins/page/index.js (1 hunks)
- packages/plugins/robot/index.js (1 hunks)
- packages/plugins/schema/index.js (1 hunks)
- packages/plugins/script/index.js (1 hunks)
- packages/plugins/tree/index.js (1 hunks)
- packages/plugins/tutorial/index.js (1 hunks)
- packages/settings/events/index.js (1 hunks)
- packages/settings/panel/index.js (1 hunks)
- packages/settings/props/index.js (2 hunks)
- packages/settings/styles/index.js (1 hunks)
- packages/toolbars/breadcrumb/index.js (1 hunks)
- packages/toolbars/clean/index.js (1 hunks)
- packages/toolbars/collaboration/index.js (1 hunks)
- packages/toolbars/fullscreen/index.js (1 hunks)
- packages/toolbars/generate-vue/index.js (1 hunks)
- packages/toolbars/lang/index.js (1 hunks)
- packages/toolbars/layout/index.js (1 hunks)
- packages/toolbars/lock/index.js (1 hunks)
- packages/toolbars/logo/index.js (1 hunks)
- packages/toolbars/logout/index.js (1 hunks)
- packages/toolbars/media/index.js (1 hunks)
- packages/toolbars/preview/index.js (1 hunks)
- packages/toolbars/redoundo/index.js (1 hunks)
- packages/toolbars/refresh/index.js (1 hunks)
- packages/toolbars/save/index.js (1 hunks)
- packages/toolbars/setting/index.js (1 hunks)
Files not summarized due to errors (8)
- packages/design-core/src/layout/DesignSettings.vue: Error: Server error. Please try again later.
- packages/plugins/block/index.js: Error: Server error. Please try again later.
- packages/plugins/data/index.js: Error: Server error. Please try again later.
- packages/design-core/src/layout/DesignToolbars.vue: Error: Server error. Please try again later.
- packages/toolbars/save/index.js: Error: Server error. Please try again later.
- packages/plugins/page/index.js: Error: Server error. Please try again later.
- packages/settings/events/index.js: Error: Server error. Please try again later.
- packages/plugins/script/index.js: Error: Server error. Please try again later.
Files skipped from review due to trivial changes (17)
- packages/plugins/bridge/index.js
- packages/plugins/i18n/index.js
- packages/plugins/schema/index.js
- packages/plugins/tree/index.js
- packages/settings/panel/index.js
- packages/settings/props/index.js
- packages/toolbars/breadcrumb/index.js
- packages/toolbars/clean/index.js
- packages/toolbars/collaboration/index.js
- packages/toolbars/fullscreen/index.js
- packages/toolbars/generate-vue/index.js
- packages/toolbars/lang/index.js
- packages/toolbars/layout/index.js
- packages/toolbars/lock/index.js
- packages/toolbars/media/index.js
- packages/toolbars/preview/index.js
- packages/toolbars/redoundo/index.js
Additional comments not posted (31)
packages/toolbars/setting/index.js (1)
13-13
: LGTM! The renaming fromcomponent
toentry
aligns with the PR objectives of standardizing naming conventions.Also applies to: 17-17
packages/settings/events/index.js (1)
13-13
: LGTM! Consistent application of the renaming strategy across different settings modules.Also applies to: 18-18
packages/settings/styles/index.js (1)
13-13
: The change is consistent and correctly implemented as per the renaming strategy described in the PR.Also applies to: 18-18
packages/toolbars/logo/index.js (1)
13-13
: This change is consistent with the other toolbar modules and aligns with the overall refactoring goals.Also applies to: 18-18
packages/toolbars/logout/index.js (2)
13-13
: Change fromcomponent
toentry
is consistent with the PR's renaming objective.
18-18
: Export ofentry
correctly reflects the updated import. Good job on maintaining consistency.packages/toolbars/refresh/index.js (2)
13-13
: Identical change as in other toolbar modules, maintaining consistency across the project.
18-18
: Export ofentry
is correctly updated to reflect the import change. Consistency is key in large refactors.packages/plugins/data/index.js (2)
13-13
: Change fromcomponent
toentry
aligns with the project-wide renaming initiative.
18-18
: Correctly updated export to useentry
, maintaining consistency and clarity in module exports.packages/plugins/robot/index.js (2)
13-13
: Consistent renaming fromcomponent
toentry
observed here as well, aligning with refactor goals.
18-18
: Export statement correctly reflects the renamed import, ensuring consistency across the codebase.packages/toolbars/save/index.js (2)
13-13
: LGTM! The import statement correctly reflects the renaming fromcomponent
toentry
.
18-18
: The export object is updated properly to useentry
instead ofcomponent
. Good consistency with the rest of the changes in the PR.packages/plugins/block/index.js (2)
13-13
: The import statement is correctly updated. Consistent with the project-wide renaming effort.
19-19
: Correct update in the export object to reflect the new naming convention.packages/plugins/page/index.js (2)
13-13
: Import statement update is consistent with the renaming strategy across the project.
19-19
: The export object correctly usesentry
as part of the renaming effort. Well done.packages/plugins/script/index.js (2)
13-13
: The changes to the import statement are correct and align with the renaming initiative in the rest of the codebase.
19-19
: Export object update is accurate and consistent with the changes made project-wide.packages/plugins/tutorial/index.js (1)
13-13
: Renaming 'component' to 'entry' aligns with the PR's objective of standardizing naming conventions.packages/plugins/materials/index.js (3)
13-13
: Renaming 'component' to 'entry' aligns with the PR's objective of standardizing naming conventions.
18-18
: Export object updated correctly to reflect the renaming. Ensure all references to 'entry' are updated across the project.
22-22
: Explicit export of 'entry' ensures it can be used elsewhere. Good practice to maintain modularity.packages/plugins/datasource/index.js (2)
14-14
: Renaming 'component' to 'entry' aligns with the PR's objective of standardizing naming conventions.
19-19
: Export object updated correctly to reflect the renaming. Ensure all references to 'entry' are updated across the project.packages/entry/docs/registry.md (2)
14-14
: Documentation updated to reflect the renaming of 'component' to 'entry'. This helps maintain consistency in the codebase.
16-16
: Addition of 'components' property in the documentation is well-documented, enhancing the customizability of the module.packages/design-core/src/layout/DesignSettings.vue (1)
5-5
: The renaming ofcomponent
toentry
aligns with the PR's objectives to standardize naming conventions.packages/design-core/src/layout/DesignToolbars.vue (1)
4-4
: Renaming ofcomponent
toentry
in toolbar components is consistent with the overall refactoring strategy.Also applies to: 7-7, 10-10
packages/design-core/src/layout/DesignPlugins.vue (1)
130-131
: The renaming ofcomponent
toentry
and the refactoring of plugin handling logic are correctly implemented. Ensure that all plugins correctly define theirentry
andicon
properties to avoid runtime errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (41)
- packages/canvas/DesignCanvas/index.js (1 hunks)
- packages/canvas/DesignCanvas/src/DesignCanvas.vue (2 hunks)
- packages/canvas/breadcrumb/index.js (1 hunks)
- packages/canvas/container/index.js (1 hunks)
- packages/entry/docs/registry.md (1 hunks)
- packages/layout/src/DesignPlugins.vue (1 hunks)
- packages/layout/src/DesignSettings.vue (1 hunks)
- packages/layout/src/DesignToolbars.vue (1 hunks)
- packages/layout/src/Main.vue (1 hunks)
- packages/plugins/block/index.js (1 hunks)
- packages/plugins/bridge/index.js (1 hunks)
- packages/plugins/data/index.js (1 hunks)
- packages/plugins/datasource/index.js (1 hunks)
- packages/plugins/i18n/index.js (1 hunks)
- packages/plugins/materials/index.js (1 hunks)
- packages/plugins/page/index.js (1 hunks)
- packages/plugins/robot/index.js (1 hunks)
- packages/plugins/schema/index.js (1 hunks)
- packages/plugins/script/index.js (1 hunks)
- packages/plugins/tree/index.js (1 hunks)
- packages/plugins/tutorial/index.js (1 hunks)
- packages/settings/events/index.js (1 hunks)
- packages/settings/panel/index.js (1 hunks)
- packages/settings/props/index.js (2 hunks)
- packages/settings/styles/index.js (1 hunks)
- packages/toolbars/breadcrumb/index.js (1 hunks)
- packages/toolbars/clean/index.js (1 hunks)
- packages/toolbars/collaboration/index.js (1 hunks)
- packages/toolbars/fullscreen/index.js (1 hunks)
- packages/toolbars/generate-vue/index.js (1 hunks)
- packages/toolbars/lang/index.js (1 hunks)
- packages/toolbars/layout/index.js (1 hunks)
- packages/toolbars/lock/index.js (1 hunks)
- packages/toolbars/logo/index.js (1 hunks)
- packages/toolbars/logout/index.js (1 hunks)
- packages/toolbars/media/index.js (1 hunks)
- packages/toolbars/preview/index.js (1 hunks)
- packages/toolbars/redoundo/index.js (1 hunks)
- packages/toolbars/refresh/index.js (1 hunks)
- packages/toolbars/save/index.js (1 hunks)
- packages/toolbars/setting/index.js (1 hunks)
Files skipped from review due to trivial changes (6)
- packages/canvas/breadcrumb/index.js
- packages/canvas/container/index.js
- packages/layout/src/DesignToolbars.vue
- packages/layout/src/Main.vue
- packages/plugins/page/index.js
- packages/toolbars/save/index.js
Files skipped from review as they are similar to previous changes (27)
- packages/entry/docs/registry.md
- packages/plugins/bridge/index.js
- packages/plugins/datasource/index.js
- packages/plugins/i18n/index.js
- packages/plugins/materials/index.js
- packages/plugins/robot/index.js
- packages/plugins/schema/index.js
- packages/plugins/tree/index.js
- packages/plugins/tutorial/index.js
- packages/settings/panel/index.js
- packages/settings/props/index.js
- packages/settings/styles/index.js
- packages/toolbars/breadcrumb/index.js
- packages/toolbars/clean/index.js
- packages/toolbars/collaboration/index.js
- packages/toolbars/fullscreen/index.js
- packages/toolbars/generate-vue/index.js
- packages/toolbars/lang/index.js
- packages/toolbars/layout/index.js
- packages/toolbars/lock/index.js
- packages/toolbars/logo/index.js
- packages/toolbars/logout/index.js
- packages/toolbars/media/index.js
- packages/toolbars/preview/index.js
- packages/toolbars/redoundo/index.js
- packages/toolbars/refresh/index.js
- packages/toolbars/setting/index.js
Additional comments not posted (8)
packages/canvas/DesignCanvas/index.js (1)
6-6
: Change fromcomponent
toentry
aligns with the PR's objectives and appears correctly implemented.packages/settings/events/index.js (1)
13-13
: Change fromcomponent
toentry
aligns with the PR's objectives and appears correctly implemented.Also applies to: 18-18
packages/plugins/data/index.js (1)
13-13
: Change fromcomponent
toentry
aligns with the PR's objectives and appears correctly implemented.Also applies to: 18-18
packages/plugins/block/index.js (1)
13-13
: Change fromcomponent
toentry
aligns with the PR's objectives and appears correctly implemented.Also applies to: 19-19
packages/plugins/script/index.js (1)
13-19
: The renaming from 'component' to 'entry' is consistent with the PR's objectives and is correctly implemented here.packages/layout/src/DesignSettings.vue (1)
5-5
: The dynamic component binding using 'setting.entry' is correctly implemented and aligns with the renaming strategy of the PR.packages/canvas/DesignCanvas/src/DesignCanvas.vue (1)
5-5
: The renaming from 'component' to 'entry' is consistently applied across the dynamic component bindings and the script section. This ensures uniformity and clarity in the codebase.Also applies to: 13-13, 181-181
packages/layout/src/DesignPlugins.vue (1)
132-133
: The renaming from 'component' to 'entry' in the plugin registration logic is correctly implemented, ensuring consistency across the codebase.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
component
toentry
across multiple components and modules for consistency and clarity. This change primarily affects the internal structure and should not impact end-user functionality.