-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(preview): fix designer-demo can't preview #554
Conversation
Warning Review failedThe pull request is closed. WalkthroughThe recent changes primarily focus on improving the preview feature within the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant HTML as preview.html
participant JS as preview.js
participant Core as design-core
participant Toolbar as Toolbar.vue
User->>HTML: Load preview.html
HTML->>JS: Load preview.js
JS->>Core: Call initPreview()
Core->>Toolbar: Initialize Toolbar with plugins
Toolbar->>User: Display preview
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- designer-demo/preview.html (1 hunks)
- designer-demo/src/preview.js (1 hunks)
- packages/design-core/index.js (1 hunks)
- packages/design-core/src/preview/src/Toolbar.vue (3 hunks)
- packages/design-core/src/preview/src/main.js (1 hunks)
Files skipped from review due to trivial changes (3)
- designer-demo/preview.html
- designer-demo/src/preview.js
- packages/design-core/index.js
Additional comments not posted (2)
packages/design-core/src/preview/src/Toolbar.vue (2)
24-26
: Ensure that the new plugin imports are correctly utilized within the component.
42-46
: The dynamic assignment of components from plugins is a good use of Vue's capabilities.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
initPreview
function to initialize and mount the preview.Improvements
Toolbar
component with new plugin imports and streamlined component setup.