fix: wrap stackable/charges items #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
dudantas
approved these changes
Mar 21, 2023
majestyotbr
approved these changes
Mar 21, 2023
PeachieDude
added a commit
to PeachieDude/canary
that referenced
this pull request
Mar 23, 2023
A discord user, Aerwix, found that plain rates for magic/skills from config werent working, after changing the rates the output was the same no matter what. i acme to look and found out that it were using staged configuration even with the rateUseStages set to false. After some tests using training/exercise weapons against a dummy and using weapons against monsters, even magic, twas confirmed that setting rateUseStages were using staged. Found out that there was no verification for skills and magic. did change the code and we ran more tests, got consistent results and got it working as intended. Now when you set rateUseStages = false it will use the rate set in config.lua Now when you set rateUseStages = true it will use the stages from stages.lua All tests were made using a brand-new char for every test, just to be sure. Tests made using training/exercise weapons against dummy with rateUseStages false and true, got expected results Tests made using weapons against monsters with rateUseStages false and true, got expected results Tests made using spells with rateUseStages false and true, got expected result IMHO the code has space for improvement, i didnt like the if/else but twas what i got working, tried other way but wasnt able to make work w/o getting an error. Feel free to discard the PR and bring a better version if so. Missing only 2 commits by the time this pr is being proposed and the said prs wont affect the change. opentibiabr#944 opentibiabr#948
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Should be possible to wrap items with different amounts; Fixes bug introduced at #840 where casks were renewing charges after wrap/unwrap. Added new attribute "AMOUNT" to store quantity information (for stackable items)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should be possible to wrap items with different amounts
Fixes bug introduced at #840 where casks were renewing charges after wrap/unwrap
Behaviour
Actual
Stackables were always being unwraped with a count of 255
Casks were renewing charges
Expected
Stackables should keep the amount after wrap/unwrap
Casks should keep the charges after wrap/unwrap
Please delete options that are not relevant.