fix: check null pointer from master on no-pvp combat.

[kaleohanopahala]

Now:
Reduces redundancy by consolidating checks.
Improves readability and maintainability by organizing conditions in a more logical and grouped manner.
Makes it easier to understand the flow of the function and how different entity types are handled (players, summons, monsters, NPC's).

[myallith]

That way, you'll end up ruining the fun for people who enjoy crashing the rival's OT lol.
kkkkk

[dudantas]

You can move this for the begin of function:

const auto &targetMaster = target ? target->getMaster() : nullptr;

After from here:

canary/src/creatures/combat/combat.cpp

Line 346 in 8b0b0ef

const auto &attackerPlayer = attacker->getPlayer();

This will avoid increasing the reference count (as this function is called a lot, it will increase the reference every time it is called).

And you can check this: too:

canary/src/creatures/combat/combat.cpp

Line 406 in 8b0b0ef

if (target->isSummon() && target->getMaster()->getPlayer() && target->getZoneType() == ZONE_NOPVP) {

And remove this:

canary/src/creatures/combat/combat.cpp

Line 410 in 8b0b0ef

const auto &targetMaster = target->getMaster();

[kaleohanopahala]

The code has been refactored.
Can test again?

Thanks dude 👯

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud