fix: pvp zone no loss

[mdbeng]

This change will prevent players from losing skills or dropping items when dieing in pvp zone, currently theres nothing involving pvp zone besides the old pvp arena which hopefully will be updated to tibia drome so this fix its something to have in mind.

pvp zone = pvp flag in rme

Description

In real tibia when a player dies within a pvp zone the player is teleported outside without losing any item or death penalty this changes will make that happen.

Behaviour

Actual

Right now if a player die in a pvp zone the player loses skill, blessings, items.

Expected

With this changes the player dieing in the pvp zone will no longer lose any item, blessing or skills.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested

• Tested in the old arena / and the on going Tibia Drome arena
• Tested dieing with and without blessings

Test Configuration:

• Server Version: Most Recent.
• Client: 13.4 / 14.5
• Operating System: Windows / Linux

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[dudantas]

It will set the monsters to not drop loot? Player::death dont't have this check?

[mdbeng]

It will set the monsters to not drop loot? Player::death dont't have this check?

It will not prevent monsters from dropping loot, it would prevent players from dropping loot if they are killed under specific circumstances. When i was doing the tests without setting that attribute if a monster killed the player will lose items, but not with players due the pvp zone. this will prevent players from losing items if a monster makes the last hit.

Still loot:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud