Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null dereferencing on onAttackedCreatureDrainHealth function #3350

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

kaleohanopahala
Copy link
Contributor

@kaleohanopahala kaleohanopahala commented Feb 8, 2025

  • null check for the target pointer and ensuring that points > 0 before proceeding.

This prevents potential crashes due to null dereferencing and avoids processing invalid damage values.

It is possible to cause a crash due to misconfiguration in some servers 😅, this fix prevents such a failure.

Copy link

sonarqubecloud bot commented Feb 8, 2025

@majestyotbr majestyotbr changed the title fix null dereferencing on onAttackedCreatureDrainHealth fuction fix: null dereferencing on onAttackedCreatureDrainHealth fuction Feb 8, 2025
@majestyotbr majestyotbr changed the title fix: null dereferencing on onAttackedCreatureDrainHealth fuction fix: null dereferencing on onAttackedCreatureDrainHealth function Feb 9, 2025
@majestyotbr majestyotbr merged commit e085973 into opentibiabr:main Feb 9, 2025
24 checks passed
@kaleohanopahala kaleohanopahala deleted the fix-combat branch February 10, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants