Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-casks-and-kegs #3343

Closed
wants to merge 1 commit into from
Closed

Conversation

mdbeng
Copy link
Contributor

@mdbeng mdbeng commented Feb 7, 2025

This will change the entire mechanics of casks and kegs to be just like real tibia. ( right click using cask/kegs and taking any type of vial, normal, strong or great vial

Description

Adjusting the cask and kegs script to react like the real interactions.

Behaviour

Actual

Before u had to use the vial in the target item ( cask or keg ) which was not the real mechanic.

Expected

You should be able to right click ( use ) the target item to transform your vials into your potions. could be any of the 3 types of vials, normal, strong, great vial. Removing the cask/keg upon finish the charges

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested all the kegs/cask with different methods such different houses, rotation, positions.
  • Tested kegs with different levels / normal characters / god

Test Configuration:

  • Server Version: Most recent.
  • Client: 13.4 / 14.5
  • Operating System: Windows / Linux

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

This will change the entire mechanics of casks and kegs to be just like real tibia. ( right click using any type of vial, normal, strong or great vial
@mdbeng mdbeng force-pushed the fix-cask-and-kegs branch from 4082961 to 56c5a8e Compare February 7, 2025 07:34
Copy link

sonarqubecloud bot commented Feb 7, 2025

@mdbeng mdbeng closed this Feb 7, 2025
@mdbeng mdbeng deleted the fix-cask-and-kegs branch February 7, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant