Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: soulcore removal logic #3326

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

omarcopires
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@FelipePaluco FelipePaluco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Can write a better message for this logging?

Like:

PLAYER_NAME dropped a soul core from MONSTER_NAME with XXX chance, or something like that?

@omarcopires omarcopires force-pushed the loglevel-soulcore branch 3 times, most recently from 267a8de to 18df3c2 Compare February 5, 2025 19:53
Copy link

sonarqubecloud bot commented Feb 5, 2025

@FelipePaluco FelipePaluco changed the title refactor: update soulcore log level refactor: soulcore removal logic Feb 5, 2025
@majestyotbr majestyotbr merged commit a173066 into opentibiabr:main Feb 6, 2025
19 checks passed
@omarcopires omarcopires deleted the loglevel-soulcore branch February 6, 2025 19:33
lucas-caminha pushed a commit to lucas-caminha/canary that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants