fix: market bitvise colision

[dudantas]

Description

This PR fixes an issue in the market system where the offer.counter value experienced collisions due to the use of a bitwise AND operation with a 16-bit mask (& 0xFFFF). When the id value exceeded multiples of 65,536 (e.g., 65,536, 131,072), the result would reset to 0, causing incorrect behavior. The fix introduces a transformation using the XOR operator (^ 0xABCDEF) before applying the mask to distribute the values more uniformly and avoid collisions.

Behaviour

Actual

When the id value in the market system reaches a multiple of 65,536, the offer.counter resets to 0 due to the bitwise AND mask (& 0xFFFF). This causes collisions and incorrect behavior in market offers.

Expected

The offer.counter should maintain unique values for different id inputs, even when they are multiples of 65,536. No collisions should occur.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

---

How Has This Been Tested

The following tests were performed to verify the fix:

• Test A: Inserted market offers with id values close to and exceeding multiples of 65,536. Verified that offer.counter values were unique and no collisions occurred.
• Test B: Ran regression tests to ensure that other parts of the market system were unaffected by the change.

---

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarQube Cloud