-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: party shared experience #3133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
approved these changes
Nov 20, 2024
|
elsongabriel
approved these changes
Nov 29, 2024
|
majestyotbr
approved these changes
Dec 29, 2024
vllworldbuilding
pushed a commit
to vllworldbuilding/canary
that referenced
this pull request
Jan 10, 2025
This fixes the party shared experience that was not providing the correct amount of experience giving the unique vocations count and party size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the party shared experience that was not providing the correct amount of experience giving the unique vocations count and party size.
Behaviour
Actual
Party shared experience does not provide the correct amount of experience.
e.g.: A monster with 6000 base experience, with stamina bonus without party it gives 9000, within a party with two unique vocations it only gives around 4800.
Party shared experience does provide the correct amount of experience.
Fixes #issuenumber
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist