Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: AreaSpawnEvent::executeEvent remove unused variable #3036

Merged
merged 4 commits into from
Oct 31, 2024
Merged

improve: AreaSpawnEvent::executeEvent remove unused variable #3036

merged 4 commits into from
Oct 31, 2024

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented Oct 31, 2024 •
edited
Loading

Removed unused variable and added pointer to const ref.

@dudantas dudantas changed the title improve: AreaSpawnEvent::executeEvent function and fix nullpointer improve: AreaSpawnEvent::executeEvent function and fix crash Oct 31, 2024
@dudantas dudantas changed the title improve: AreaSpawnEvent::executeEvent function and fix crash improve: AreaSpawnEvent::executeEvent remove unused variable Oct 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dudantas dudantas merged commit 653e064 into main Oct 31, 2024
34 of 35 checks passed
@dudantas dudantas deleted the dudantas/fix-raid-nullpointer-and-improve-function branch October 31, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beats-dh beats-dh beats-dh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudantas @beats-dh