Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floor in entrance of poi is not allowed to walk on it #3144

Closed
3 of 5 tasks
Regeton5306 opened this issue Nov 22, 2024 · 5 comments · Fixed by #3196
Closed
3 of 5 tasks

floor in entrance of poi is not allowed to walk on it #3144

Regeton5306 opened this issue Nov 22, 2024 · 5 comments · Fixed by #3196
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Regeton5306
Copy link

Regeton5306 commented Nov 22, 2024

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

When using the pickaxe on the stone, the floor is created but it does not let you pass, you just bounce and it tells you there is not enough room and in the console an error message appears [combatTypeToIndex] Combat type 255 is out of range, called line '2480:54' in 'bool __cdecl Monster::isImmune(enum CombatType_t) const'

image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Regeton5306 Regeton5306 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 22, 2024
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Nov 22, 2024
@helenarubra
Copy link

Have a same problem

@Mifuno
Copy link

Mifuno commented Dec 25, 2024

IglaOTS_40qGwVdmSL.mp4

yup same problem

@jeansouzak
Copy link
Contributor

This issue occurs when a walkable tile (e.g., grass, dirt, pavement, sandstone) is spawned above a non-walkable tile (e.g., lava, shallow water). I tested this by creating (spawning) these items as a GOD using the /i command and placing a walkable item above non-walkable spots.

Example:

cant-walk-floor.mp4

@jeansouzak
Copy link
Contributor

@Regeton5306
Specific Solution for The Pits of Inferno Quest Floor

  1. Navigate to data-otservbr-global/scripts/lib/register_actions.lua.
  2. Locate the section labeled -- The Pits of Inferno Quest
  3. Replace the following code:
for i = 1, #lava do
    Game.createItem(5815, 1, lava[i])
end

with this:

for i = 1, #lava do
    local lavaTile = Tile(lava[i]):getItemById(21477)
    if lavaTile then
        lavaTile:transform(5815)
    end
end

When using Tile::transform() it works well to solve poi entrance.

@Mifuno
Copy link

Mifuno commented Dec 26, 2024

Tested the fix for POI from Jeansouzak and it works

IglaOTStest_dmQuIC16qP.mp4

vllworldbuilding pushed a commit to vllworldbuilding/canary that referenced this issue Jan 10, 2025
…iabr#3196)

Implements an alternative solution to handle lava
tiles in The Pits of Inferno Quest. The logic in register_actions.lua
has been modified to transform existing lava items (ID: 21477) into the
floor item (ID: 5815) using Tile:getItemById and Item:transform, instead
of relying on Game.createItem.
This addresses an issue where lava tiles in The Pits of Inferno Quest
were not behaving as expected
Resolves opentibiabr#3144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants