Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use astype for torch.Tensor #2242

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Aug 16, 2024

Only apply .astype to the np version in Metagraph._process_weights_and_bonds. Added test.
CC: @mvds00

@thewhaleking thewhaleking requested a review from a team August 16, 2024 11:52
@thewhaleking thewhaleking requested a review from a team August 17, 2024 05:57
@thewhaleking thewhaleking merged commit 71b51b2 into master Aug 30, 2024
14 checks passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/incompatible-tensor-attributes branch August 30, 2024 14:16
ibraheem-opentensor pushed a commit that referenced this pull request Sep 4, 2024
* Broke apart the logic of use_torch and not _process_weights_and_bonds to more clearly read it. Only apply .astype to the np version.

* Add test for weights and bonds using torch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants