Release/6.10.0

CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 6.10.0 / 2024-03-25
+
+## What's Changed
+* handle req args by parsing and raising by @ifrit98 in https://github.com/opentensor/bittensor/pull/1733
+* Replace wildcard imports with specific imports by @brueningf in https://github.com/opentensor/bittensor/pull/1724
+* Logging Refactor by @sepehr-opentensor in https://github.com/opentensor/bittensor/pull/1751
+* Update DEBUGGING.md by @e-gons in https://github.com/opentensor/bittensor/pull/1755
+* fix: nonce implementation by @GentikSolm in https://github.com/opentensor/bittensor/pull/1754
+
+## New Contributors
+* @sepehr-opentensor made their first contribution in https://github.com/opentensor/bittensor/pull/1751
+* @e-gons made their first contribution in https://github.com/opentensor/bittensor/pull/1755
+* @GentikSolm made their first contribution in https://github.com/opentensor/bittensor/pull/1754
+
+**Full Changelog**: https://github.com/opentensor/bittensor/compare/v6.9.3...v6.10.0
+
+
 ## 6.9.3 / 2024-03-12
 
 ## What's Changed

VERSION

@@ -1 +1 @@
-6.9.3
+6.10.0

bittensor/__init__.py

@@ -27,7 +27,7 @@
 nest_asyncio.apply()
 
 # Bittensor code and protocol version.
-__version__ = "6.9.3"
+__version__ = "6.10.0"
 
 version_split = __version__.split(".")
 __version_as_int__: int = (
@@ -206,25 +206,94 @@ def debug(on: bool = True):
     },
 }
 
-from .errors import *
+from .errors import (
+    BlacklistedException,
+    ChainConnectionError,
+    ChainError,
+    ChainQueryError,
+    ChainTransactionError,
+    IdentityError,
+    InternalServerError,
+    InvalidRequestNameError,
+    KeyFileError,
+    MetadataError,
+    NominationError,
+    NotDelegateError,
+    NotRegisteredError,
+    NotVerifiedException,
+    PostProcessException,
+    PriorityException,
+    RegistrationError,
+    RunException,
+    StakeError,
+    SynapseDendriteNoneException,
+    SynapseParsingError,
+    TransferError,
+    UnknownSynapseError,
+    UnstakeError,
+)
 
 from substrateinterface import Keypair as Keypair
-from .config import *
-from .keyfile import *
-from .wallet import *
+from .config import InvalidConfigFile, DefaultConfig, config, T
+from .keyfile import (
+    serialized_keypair_to_keyfile_data,
+    deserialize_keypair_from_keyfile_data,
+    validate_password,
+    ask_password_to_encrypt,
+    keyfile_data_is_encrypted_nacl,
+    keyfile_data_is_encrypted_ansible,
+    keyfile_data_is_encrypted_legacy,
+    keyfile_data_is_encrypted,
+    keyfile_data_encryption_method,
+    legacy_encrypt_keyfile_data,
+    encrypt_keyfile_data,
+    get_coldkey_password_from_environment,
+    decrypt_keyfile_data,
+    keyfile,
+    Mockkeyfile,
+)
+from .wallet import display_mnemonic_msg, wallet
+
+from .utils import (
+    ss58_to_vec_u8,
+    unbiased_topk,
+    version_checking,
+    strtobool,
+    strtobool_with_default,
+    get_explorer_root_url_by_network_from_map,
+    get_explorer_root_url_by_network_from_map,
+    get_explorer_url_for_network,
+    ss58_address_to_bytes,
+    U16_NORMALIZED_FLOAT,
+    U64_NORMALIZED_FLOAT,
+    u8_key_to_ss58,
+    hash,
+    wallet_utils,
+)
 
-from .utils import *
 from .utils.balance import Balance as Balance
-from .chain_data import *
+from .chain_data import (
+    AxonInfo,
+    NeuronInfo,
+    NeuronInfoLite,
+    PrometheusInfo,
+    DelegateInfo,
+    StakeInfo,
+    SubnetInfo,
+    SubnetHyperparameters,
+    IPInfo,
+    ProposalCallData,
+    ProposalVoteData,
+)
 from .subtensor import subtensor as subtensor
 from .cli import cli as cli, COMMANDS as ALL_COMMANDS
-from .btlogging import logging as logging
+from .btlogging import logging
 from .metagraph import metagraph as metagraph
 from .threadpool import PriorityThreadPoolExecutor as PriorityThreadPoolExecutor
 
-from .synapse import *
-from .stream import *
-from .tensor import *
+from .synapse import TerminalInfo, Synapse
+from .stream import StreamingSynapse
+from .tensor import tensor, Tensor
 from .axon import axon as axon
 from .dendrite import dendrite as dendrite
 
@@ -239,6 +308,6 @@ def debug(on: bool = True):
     subtensor.config(),
     PriorityThreadPoolExecutor.config(),
     wallet.config(),
-    logging.config(),
+    logging.get_config(),
 ]
 defaults = config.merge_all(configs)

bittensor/axon.py

@@ -914,14 +914,25 @@ async def default_verify(self, synapse: bittensor.Synapse):
             # Build the unique endpoint key.
             endpoint_key = f"{synapse.dendrite.hotkey}:{synapse.dendrite.uuid}"
 
-            # Check the nonce from the endpoint key.
+            # Check the nonce from the endpoint key with 4 second delta
+            allowedDelta = 4000000000
+
+            # Requests must have nonces to be safe from replays
+            if synapse.dendrite.nonce is None:
+                raise Exception("Missing Nonce")
+
+            # If we don't have a nonce stored, ensure that the nonce falls within
+            # a reasonable delta.
+            if (
+                self.nonces.get(endpoint_key) is None
+                and synapse.dendrite.nonce <= time.time_ns() - allowedDelta
+            ):
+                raise Exception("Nonce is too old")
             if (
-                endpoint_key in self.nonces.keys()
-                and self.nonces[endpoint_key] is not None
-                and synapse.dendrite.nonce is not None
+                self.nonces.get(endpoint_key) is not None
                 and synapse.dendrite.nonce <= self.nonces[endpoint_key]
             ):
-                raise Exception("Nonce is too small")
+                raise Exception("Nonce is too old")
 
             if not keypair.verify(message, synapse.dendrite.signature):
                 raise Exception(
@@ -1190,7 +1201,7 @@ async def preprocess(self, request: Request) -> bittensor.Synapse:
             {
                 "version": str(bittensor.__version_as_int__),
                 "uuid": str(self.axon.uuid),
-                "nonce": f"{time.monotonic_ns()}",
+                "nonce": f"{time.time_ns()}",
                 "status_message": "Success",
                 "status_code": "100",
             }