Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch bad endpoint protocol #1296

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Catch bad endpoint protocol #1296

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d55880e
catch protocol not good
camfairchild Apr 21, 2023
159cae8
add protocol 4
camfairchild Apr 21, 2023
27eb580
catch assertion and return bool
camfairchild Apr 21, 2023
78f54be
catch assertion errors
camfairchild Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions bittensor/_endpoint/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def from_neuron( neuron: Union['bittensor.NeuronInfo', 'bittensor.NeuronInfoLite
def from_dict(endpoint_dict: dict) -> 'bittensor.Endpoint':
""" Return an endpoint with spec from dictionary
"""
endpoint.assert_format(
if not endpoint.assert_format(
version = endpoint_dict['version'],
uid = endpoint_dict['uid'],
hotkey = endpoint_dict['hotkey'],
Expand All @@ -116,7 +116,8 @@ def from_dict(endpoint_dict: dict) -> 'bittensor.Endpoint':
ip_type = endpoint_dict['ip_type'],
protocol = endpoint_dict['protocol'],
coldkey = endpoint_dict['coldkey']
)
):
raise ValueError('Invalid endpoint dict')
return endpoint_impl.Endpoint(
version = endpoint_dict['version'],
uid = endpoint_dict['uid'],
Expand Down Expand Up @@ -152,7 +153,10 @@ def from_tensor( tensor: torch.LongTensor) -> 'bittensor.Endpoint':
endpoint_bytes = bytearray( endpoint_list )
endpoint_string = endpoint_bytes.decode('utf-8')
endpoint_dict = json.loads( endpoint_string )
return endpoint.from_dict(endpoint_dict)
try:
return endpoint.from_dict(endpoint_dict)
except ValueError:
return endpoint.dummy()

@staticmethod
def dummy():
Expand Down