Search ecosystem split #53
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
thanks for the update @karamba228 - I've added a few more comments
| // import { maturityColor, maturityIconPath } from "@/components/Maturity"; | ||
| // import { riskColor, riskIconPath } from "@/components/Risk"; |
| @@ -4,9 +4,10 @@ import { NextRequest } from "next/server"; | |||
| export async function GET(request: NextRequest) { | |||
| const searchParams = request.nextUrl.searchParams; | |||
| const query = searchParams.get("query"); | |||
| const ecosystem = searchParams.get("ecosystem") || ""; | |||
There was a problem hiding this comment.
this will fail with "" will it not?
There was a problem hiding this comment.
I don't think we are using this file anymore. It looks to be handling package search within the API
src/utils/search_conda.ts
Outdated
| } catch (error) { | ||
| const errorMessage = | ||
| error instanceof Error ? error.message : "An unknown error occurred."; | ||
| toast.error(`Error fetching data from Anaconda.org: ${errorMessage}`); |
There was a problem hiding this comment.
have you tested this toast? can you send a screenshot? it looks like it is running on the server
There was a problem hiding this comment.
You are right, toast does not work server side, I tried propagating the error up to the client side page but the error does not propagate with debounce: lodash/lodash#4449. I looked into the suggested solution and tried implementing that but the error would not propagate: lodash/lodash#4815 (comment)
src/utils/search_npm.ts
Outdated
| const errorMessage = | ||
| error instanceof Error ? error.message : "An unknown error occurred."; | ||
| toast.error(`Error fetching data from npm registry: ${errorMessage}`); | ||
| throw new Error(`Error fetching data from npm registry: ${errorMessage}`); |
There was a problem hiding this comment.
Why are you throwing a new error here?
| throw new Error(`Error fetching data from npm registry: ${errorMessage}`); | |
| throw error; |
|
how is this coming along? |
|
@srossross I am blocked with debounce not allowing the propagation of the error to the client side component for the toast to work properly. Retrieving packages from each respective api should work now. I mentioned the block in the previous comment with references to issues I have researched #53 (comment) |
Weird behavior. the search seems to prioritize Pypi no matter what.
For example, I am using pandas to test pypi and conda packages:
If
pypiis selected and I search for "Pandas" the results show up as expected. But if I selectcodafor the ecosystem and search for "Pandas" the same output is generated.Where the differences start to appear is if I select
pypiand search for conda/pandas, pypi results are prioritized. likewise, if I search for conda/pandas with conda ecosystem selected, conda results show up at the top of the list.