Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add text search results to search sidebar #209

Closed
kellyi opened this issue Feb 18, 2019 · 3 comments
Closed

Add text search results to search sidebar #209

kellyi opened this issue Feb 18, 2019 · 3 comments
Assignees
Milestone

Comments

@kellyi
Copy link
Contributor

kellyi commented Feb 18, 2019

Overview

The prior UI had a way to list search results in text in the search sidebar:

screen shot 2019-02-18 at 4 09 27 pm

We should recreate a similar functionality.

Describe the solution you'd like

List search results in text form in the search sidebar somehow. This could involve adding a new tab to that sidebar or adding the list beneath the existing search bar.

Each facility name should use a react router Link tag to link to /facilities/:id where :id is the facility's oar_id.

@jwalgran jwalgran added this to the 2.0 Release milestone Feb 19, 2019
@jwalgran jwalgran added the question Further information is requested label Feb 21, 2019
@jwalgran
Copy link
Contributor

Labeled as a question because I am not sure we want to carry this behavior forward.

As of now we have implemented text searching as just another filter that combines with the dropdown list selections to narrow the search results.

@katieashaw and @nataliegrillon, is having the text filter behave differently a desired feature?

@katieashaw
Copy link

Coming back on a few points in this thread, to be certain I've understood correctly:

  • Having a list of the facilities returned by a search displayed in a column as per the screenshot, which you can then click onto take you to the facility details - and have the map zoom to that facility - is a desired feature that we would like to keep.

  • When it comes to text searching on the site, ideally we would like there to be an elastic, free text search box so users could search using terms such as "socks", "organic" etc, and have results returned with have been tagged with those keywords. Is that possible?

@nataliegrillon Jump into add any nuance / Qs you may have!

@jwalgran jwalgran added 1 queue and removed 1 labels Feb 21, 2019
@kellyi kellyi added in progress and removed queue labels Feb 27, 2019
@kellyi kellyi self-assigned this Feb 27, 2019
kellyi pushed a commit that referenced this issue Mar 1, 2019
- add an order_by('name') clause to the queryset in all_contributors to
sort the results so they'll display alphabetically by name in the client

Connects #209
@kellyi
Copy link
Contributor Author

kellyi commented Mar 3, 2019

I created #244 for restoring the map zoom interactions. Seems like we should also make the map zoom to the marker when the user visits /facilities/:oarID directly and the facility data returns from the API.

@jwalgran jwalgran removed the question Further information is requested label Mar 5, 2019
kellyi added a commit that referenced this issue Mar 5, 2019
Create facilities tab & display text search results

Connects #209
Connects #227
Connects #127
Connects #123
@jwalgran jwalgran closed this as completed Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants