Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to jest@28 #937

Merged
merged 4 commits into from
May 6, 2022
Merged

chore: update to jest@28 #937

merged 4 commits into from
May 6, 2022

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented May 3, 2022

Types

  • 🧹 Chores

Background or solution

Changelog

@bytemain bytemain force-pushed the chore/update-jest branch from 4b36ce9 to b67657d Compare May 6, 2022 03:28
@bytemain
Copy link
Member Author

bytemain commented May 6, 2022

jest@28 会使我们的一个依赖 nanoid 无法测试,如官方文档所提到的 workaround:microsoft/accessibility-insights-web#5421 (comment)

如其中提到的,我们使用一个自定义的 jest resovler 来做这件事。

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #937 (fe7cadf) into main (8b3b20f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   58.51%   58.52%           
=======================================
  Files        1225     1225           
  Lines       75526    75528    +2     
  Branches    15696    15697    +1     
=======================================
+ Hits        44197    44201    +4     
+ Misses      28557    28555    -2     
  Partials     2772     2772           
Impacted Files Coverage Δ
packages/connection/src/common/rpcProtocol.ts 81.86% <0.00%> (-0.36%) ⬇️
...ages/file-service/src/node/file-service-watcher.ts 66.48% <0.00%> (+0.55%) ⬆️
packages/core-common/src/node/port.ts 46.96% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3b20f...fe7cadf. Read the comment docs.

@erha19 erha19 merged commit 7bbee7e into main May 6, 2022
@erha19 erha19 deleted the chore/update-jest branch May 6, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants