Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update openTextDocument API #1126

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

AhkunTa
Copy link
Member

@AhkunTa AhkunTa commented May 27, 2022

Types

  • 🎉 New Features

Background or solution

close #909

Changelog

improve openTextDocument API supported

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1126 (b612835) into main (2467b10) will decrease coverage by 0.82%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   58.84%   58.01%   -0.83%     
==========================================
  Files        1226     1232       +6     
  Lines       75739    77293    +1554     
  Branches    15746    16142     +396     
==========================================
+ Hits        44565    44845     +280     
- Misses      28417    29558    +1141     
- Partials     2757     2890     +133     
Flag Coverage Δ
jsdom 52.67% <42.85%> (-0.74%) ⬇️
node 15.90% <4.76%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/editor/src/browser/workbench-editor.service.ts 61.09% <ø> (-1.42%) ⬇️
packages/extension/src/common/vscode/doc.ts 100.00% <ø> (ø)
packages/editor/src/browser/untitled-resource.ts 42.04% <25.00%> (-5.96%) ⬇️
...xtension/src/browser/vscode/api/main.thread.doc.ts 61.49% <28.57%> (-0.54%) ⬇️
...sion/src/hosted/api/vscode/doc/doc-manager.host.ts 51.70% <60.00%> (-1.12%) ⬇️
...rminal-next/src/browser/terminal.ext.host.proxy.ts 2.63% <0.00%> (-42.11%) ⬇️
...inal-next/src/browser/terminal.internal.service.ts 55.93% <0.00%> (-16.95%) ⬇️
...kages/terminal-next/src/node/pty.manager.remote.ts 64.00% <0.00%> (-13.78%) ⬇️
packages/overlay/src/browser/dialog.service.ts 20.00% <0.00%> (-10.62%) ⬇️
...tension/src/hosted/api/vscode/ext.host.treeview.ts 53.68% <0.00%> (-10.08%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2467b10...b612835. Read the comment docs.

@erha19 erha19 added this to the 2.19 milestone May 31, 2022
@erha19 erha19 mentioned this pull request May 31, 2022
15 tasks
@AhkunTa AhkunTa force-pushed the feat/update-openTextDocument-api branch from 54536a8 to b612835 Compare July 6, 2022 09:09
@erha19 erha19 merged commit ce748f5 into main Jul 6, 2022
@erha19 erha19 deleted the feat/update-openTextDocument-api branch July 6, 2022 11:44
@erha19 erha19 changed the title feat: update openTextDocument Api feat: update openTextDocument API Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 完善 openTextDocument
3 participants