Replace vendored osmosis-osm-binary code with Maven hosted equivalent #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28a5025 to
13b849c
Compare
|
Don't know if you think this warrants a note somewhere in the docs, but as noted here #85 (comment) this breaks compatibility with Android 7 and earlier. |
|
I must admit I'd completely forgotten about that discussion. Any suggestions on where it should go? The next release notes perhaps? |
That's probably best. |
|
Done. I've added a "Pending changes" section to the release notes containing the changes since last version and included a note about breaking Android 7 compatibility. Let me know if it makes sense. Feel free to send through some improved wording. |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
osmosis-osm-binaryproject containing vendored PBF code with a direct dependency on theorg.openstreetmap.pbf:osmpbf:1.5.0module from Maven central.