Speedup suggestions widget #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache calls to delegate' `sizeHint`.
Optimize delegate' `sizeHint` implementation.
morinted
approved these changes
Feb 6, 2022
|
I've been trying out this pull request for a while, and the suggestions widget feels a lot snappier than it used to. I can't say for sure that there isn't a slowdown when the number of widget entries grow, but it's a lot better than it used to be. |
cdaa926 to
a8b6699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Optimize the delegate'
sizeHintimplementation and cache calls to it.Closes #1477.
Pull Request Checklist
[ ] Changes have tests