Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ortho rules for Magnum/Stanley's theory rules.. #1092

Closed
wants to merge 3 commits into from

Conversation

stanographer
Copy link
Contributor

Added rules that account for orthographical errors that I've encountered while using Plover using the non-standard dictionary. Please review for efficiency suggestions or possible consolidations of rules as most of these, I added as I came across them.

Also added this line from PyQt5.QtWebEngineWidgets import QWebEngineView toregistry.py that was causing errors on launch.

@user202729
Copy link
Member

You could add y+ify to the i+ify ones. Such as pretty+ify.

@benoit-pierre
Copy link
Member

benoit-pierre commented Dec 16, 2019

Also added this line from PyQt5.QtWebEngineWidgets import QWebEngineView toregistry.py that was causing errors on launch.

What errors? I think I remember a similar error due to a hack in one plugin (spectra-lexer I think), but I believe this has been resolved. In any case this does not belong in this PR, and certainly not in a commit with no relation.

Copy link
Member

@benoit-pierre benoit-pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the change in registry.py. Unrelated formatting changes should be removed too.

Some tests would be nice: see test/test_orthography.py.

I'm not sure we want the Spanish system in the core, a dedicated plugin makes more sense.

@benoit-pierre benoit-pierre mentioned this pull request Apr 1, 2021
22 tasks
@benoit-pierre
Copy link
Member

Closing in favor of #1212.

benoit-pierre added a commit that referenced this pull request Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants