Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding QA tests for the new corgi UI #523

Merged
merged 7 commits into from
Jan 24, 2023
Merged

adding QA tests for the new corgi UI #523

merged 7 commits into from
Jan 24, 2023

Conversation

omehes
Copy link
Contributor

@omehes omehes commented Jan 17, 2023

These are the complete QA tests for the new corgi UI
Note, that the @pytestrail.case("") does not have a case number as the test cases are not yet updated in testrail. This will happen soon (I almost forgot about it)...

@omehes omehes self-assigned this Jan 17, 2023
@omehes
Copy link
Contributor Author

omehes commented Jan 17, 2023

@openstax/ce-tech Integration tests failed due to independecy (playwright) issue... not sure...

Copy link
Contributor

@therealmarv therealmarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good for me 👍

@omehes
Copy link
Contributor Author

omehes commented Jan 20, 2023

@therealmarv FYI: in case you come back to this PR, I added more commits... but I am still not sure how to solve the authentication issue (state.json)

@philschatz philschatz changed the base branch from main to corgi-svelte January 23, 2023 17:30
Copy link
Contributor

@TylerZeroMaster TylerZeroMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these two small problems, this looks and works very well. If you want to resolve the merge conflict, you can just copy the circleci config from corgi-svelte onto this branch so that the contents match on both branches. I can do it if you would like.

@@ -19,4 +37,5 @@ def chrome_page():
@pytest.fixture
def corgi_base_url(base_url):
"""Return local corgi url"""
base_url = "https://corgi-514.ce.openstax.org/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

@pytest.fixture
def corgi_base_url(base_url):
    """Return local corgi url"""
    return base_url

and use pytest --base-url "https://corgi-514.ce.openstax.org"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right

# WHEN: Input fields are filled and a job check box is selected
home.fill_repo_field(repo)
home.fill_book_field(book)
home.fill_version_field(book)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

home.fill_version_field(book) should probably be home.fill_version_field(version)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yes. thanks!!!

@omehes
Copy link
Contributor Author

omehes commented Jan 23, 2023

@TylerZeroMaster I made the changes (no conflict). I assume I can Squash and Merge my branch into corgi_svelte, right?

@omehes omehes merged commit 77e4ba7 into corgi-svelte Jan 24, 2023
@omehes omehes deleted the new_corgi branch January 24, 2023 19:59
TylerZeroMaster pushed a commit that referenced this pull request Feb 24, 2023
* try to use current ubuntu image in CircleCI
* use no terminal in CircleCI tests for poetry
see
python-poetry/poetry#7184
for details of the issue.

* added testrail case numbers and parametrize
* removed all mark.smoke marker - not needed
* added more testrail case numbers
Co-authored-by: therealmarv <1050582+therealmarv@users.noreply.github.com>
TylerZeroMaster pushed a commit that referenced this pull request Feb 24, 2023
* try to use current ubuntu image in CircleCI
* use no terminal in CircleCI tests for poetry
see
python-poetry/poetry#7184
for details of the issue.

* added testrail case numbers and parametrize
* removed all mark.smoke marker - not needed
* added more testrail case numbers
Co-authored-by: therealmarv <1050582+therealmarv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants