-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding QA tests for the new corgi UI #523
Conversation
@openstax/ce-tech Integration tests failed due to independecy (playwright) issue... not sure... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good for me 👍
see python-poetry/poetry#7184 for details of the issue.
@therealmarv FYI: in case you come back to this PR, I added more commits... but I am still not sure how to solve the authentication issue (state.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these two small problems, this looks and works very well. If you want to resolve the merge conflict, you can just copy the circleci config from corgi-svelte onto this branch so that the contents match on both branches. I can do it if you would like.
@@ -19,4 +37,5 @@ def chrome_page(): | |||
@pytest.fixture | |||
def corgi_base_url(base_url): | |||
"""Return local corgi url""" | |||
base_url = "https://corgi-514.ce.openstax.org/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
@pytest.fixture
def corgi_base_url(base_url):
"""Return local corgi url"""
return base_url
and use pytest --base-url "https://corgi-514.ce.openstax.org"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right
# WHEN: Input fields are filled and a job check box is selected | ||
home.fill_repo_field(repo) | ||
home.fill_book_field(book) | ||
home.fill_version_field(book) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
home.fill_version_field(book)
should probably be home.fill_version_field(version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yes. thanks!!!
@TylerZeroMaster I made the changes (no conflict). I assume I can Squash and Merge my branch into corgi_svelte, right? |
* try to use current ubuntu image in CircleCI * use no terminal in CircleCI tests for poetry see python-poetry/poetry#7184 for details of the issue. * added testrail case numbers and parametrize * removed all mark.smoke marker - not needed * added more testrail case numbers Co-authored-by: therealmarv <1050582+therealmarv@users.noreply.github.com>
* try to use current ubuntu image in CircleCI * use no terminal in CircleCI tests for poetry see python-poetry/poetry#7184 for details of the issue. * added testrail case numbers and parametrize * removed all mark.smoke marker - not needed * added more testrail case numbers Co-authored-by: therealmarv <1050582+therealmarv@users.noreply.github.com>
These are the complete QA tests for the new corgi UI
Note, that the
@pytestrail.case("")
does not have a case number as the test cases are not yet updated in testrail. This will happen soon (I almost forgot about it)...