Fix test vars to fix downstream tests #576
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramite
approved these changes
Jan 6, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paramite, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elfiesmelfie
requested changes
Jan 6, 2025
ci/vars-autoscaling-tempest.yml
Outdated
| @@ -6,7 +6,7 @@ cifmw_test_operator_tempest_container: openstack-tempest-all | |||
| cifmw_test_operator_tempest_image_tag: 'current-podified' | |||
| # This value is used to populate the `tempestconfRun` parameter of the Tempest CR: https://openstack-k8s-operators.github.io/test-operator/crds.html#tempest-custom-resource | |||
| # https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/test_operator/defaults/main.yml | |||
| cifmw_test_operator_tempest_tempestconf_config: | |||
| cifmw_tempest_tempestconf_config: | |||
There was a problem hiding this comment.
You don't have to rename it again, you could define both variables.
Or define a tempest_conf var (with this value), and then set both the new and old var names to "{{ tempest_conf }}"
There was a problem hiding this comment.
Thanks for the suggestion
22e33e4 to
9d183e1
Compare
9d183e1 to
30d8e96
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes changes from #548
This makes our downstream tests fail. We need to wait for the ciframework change to get downstream first. Let's get back to this in like a month and try again.