Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't label all host files with container_file_t: #202

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Don't label all host files with container_file_t: #202

merged 1 commit into from
Oct 11, 2023

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Oct 11, 2023 •
edited
Loading

@rabi rabi requested a review from jlarriba October 11, 2023 09:04
@rabi rabi changed the title Don't label /etc/localtime with container_file_t: Don't label all host files with container_file_t: Oct 11, 2023
@rabi rabi requested a review from jlarriba October 11, 2023 09:22
gibizer
gibizer approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

templates/ceilometercompute/config/ceilometer_agent_compute.json Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, jlarriba, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 338f29e into openstack-k8s-operators:main Oct 11, 2023
@rebtoor rebtoor mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibizer gibizer gibizer approved these changes

@jlarriba jlarriba jlarriba approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@jlarriba jlarriba

@gibizer gibizer

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabi @jlarriba @gibizer