Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: Support large DNS payloads #334

Merged
merged 1 commit into from
Jan 15, 2025
Merged

DNS: Support large DNS payloads #334

merged 1 commit into from
Jan 15, 2025

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jan 13, 2025

When edpm nodes use the dnsmasq we deploy in OCP they will not be able to get large DNS responses.

DNS messages are restricted to 512 octets, and tools such as dig will try detect that the response has been truncated and then use TCP mode instead.

We can see this happen if we run inside the edpm node the following:

$ dig cisco.com TXT
;; Truncated, retrying in TCP mode.

With this patch we make the dns OCP service expose the TCP port so the alternative TCP mechanism can be used.

When edpm nodes use the dnsmasq we deploy in OCP they will not be able
to get large DNS responses.

DNS messages are restricted to 512 octets, and tools such as dig will
try detect that the response has been truncated and then use TCP mode
instead.

We can see this happen if we run inside the edpm node the following:

```
$ dig cisco.com TXT
;; Truncated, retrying in TCP mode.
```

With this patch we make the dns OCP service expose the TCP port so the
alternative TCP mechanism can be used.
Copy link

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hoping there isn't some larger story to why this is currently missing

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/243f36801eba4897bcbb786a43b922b3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 15s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 41m 20s

@Akrog
Copy link
Contributor Author

Akrog commented Jan 14, 2025

recheck

@Akrog Akrog requested a review from stuggi January 14, 2025 11:27
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks Gorka!

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, csibbitt, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Jan 14, 2025

/test functional

@stuggi
Copy link
Contributor

stuggi commented Jan 14, 2025

the failing test is not related. I'll have a look into that. I think we have seen this in the past, looks like an issue in that bgpconfiguration functional test.

@stuggi
Copy link
Contributor

stuggi commented Jan 14, 2025

GET https://quay.io/v2/: unexpected status code 502 Bad Gateway

@stuggi
Copy link
Contributor

stuggi commented Jan 14, 2025

/retest

1 similar comment
@stuggi
Copy link
Contributor

stuggi commented Jan 15, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit f6db1ec into main Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants