-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS: Support large DNS payloads #334
Conversation
When edpm nodes use the dnsmasq we deploy in OCP they will not be able to get large DNS responses. DNS messages are restricted to 512 octets, and tools such as dig will try detect that the response has been truncated and then use TCP mode instead. We can see this happen if we run inside the edpm node the following: ``` $ dig cisco.com TXT ;; Truncated, retrying in TCP mode. ``` With this patch we make the dns OCP service expose the TCP port so the alternative TCP mechanism can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - hoping there isn't some larger story to why this is currently missing
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/243f36801eba4897bcbb786a43b922b3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 25s |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm thanks Gorka!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, csibbitt, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test functional |
the failing test is not related. I'll have a look into that. I think we have seen this in the past, looks like an issue in that bgpconfiguration functional test. |
GET https://quay.io/v2/: unexpected status code 502 Bad Gateway |
/retest |
1 similar comment
/retest |
When edpm nodes use the dnsmasq we deploy in OCP they will not be able to get large DNS responses.
DNS messages are restricted to 512 octets, and tools such as dig will try detect that the response has been truncated and then use TCP mode instead.
We can see this happen if we run inside the edpm node the following:
With this patch we make the dns OCP service expose the TCP port so the alternative TCP mechanism can be used.