Openvswitch package install required #866
Conversation
| @@ -33,6 +33,8 @@ edpm_bootstrap_packages_bootstrap: | |||
| - nftables | |||
| - NetworkManager | |||
| - openstack-selinux | |||
| - openvswitch | |||
There was a problem hiding this comment.
openvswitch should get installed by edpm_ovs, which is included by playbooks/configure_network.yml
There was a problem hiding this comment.
yes installed openvswitch during configure nework but failing for pre provisioned node.
we need to install in configure ovs dpdk which is called before configure network. we cannot change the order.
so to avoid redundant, i am going to include edpm_ovs role in configure_ovs_dpdk.yml playbook.
this is only duplication for ovs dpdk. for other features only via configire_network.yml playbook.
There was a problem hiding this comment.
or can we move this ovs install steps to bootsrap commonly?
| @@ -33,6 +33,8 @@ edpm_bootstrap_packages_bootstrap: | |||
| - nftables | |||
| - NetworkManager | |||
| - openstack-selinux | |||
| - openvswitch | |||
| - os-net-config | |||
There was a problem hiding this comment.
already installed by edpm_network_config, which actually includes edpm_bootstrap/tasks/packages.yml, and then the very next task is to install os-net-config, so this could be redundant.
There was a problem hiding this comment.
but os-net-config mantioned in meta default arguments_spec.yaml,
can i remove this os-net-config also in arguments_spec default?
a9bfb49 to
3f75ccb
Compare
3f75ccb to
66e18d4
Compare
| ansible.builtin.dnf: | ||
| name: openvswitch | ||
| state: present | ||
|
|
There was a problem hiding this comment.
would you want to use edpm_ovs/tasks/install.yml here instead? The other task that would be done is to ensure that the openvswitch service is started. Does dpdk require that?
There was a problem hiding this comment.
using edpm_ovs/tasks/install.yml in configure ovs dpdk playbook, will create the enabled and running ovs part duplication also.
Configure ovs dpdk is require only openvswitch package installation and not to be enabled and running.
configure network is common for all feature and configure ovs dpdk is specific to only ovs dpdk.
better we can add only openvswitch installation here and we can avoid redundant ovs configuration and enabled part if we are not using ovs install.yml here.
This change is to fix the openvswitch package missing issue during configure ovs dpdk for pre provisioned EDPM nodes. We already have ovs packages installation, ovs services are enabled and running part in configure-network which is common for all deployment. To avoid issue in configure ovs dpdk, we are adding only openvswitch package installation part and not using existing edpm_ovs install.yml task to avoid complete redundat like ovs services configuration, enable and running part.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jaganathancse, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
66e18d4 to
047bc57
Compare
|
New changes are detected. LGTM label has been removed. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/03dfb4ed3e104e02b880689b39decdab ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 56s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d769aee8d1b9428580fc0aea9f52b608 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 51s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e555bfc640894a609c8ff61b0e04ef24 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 47s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1ffccc647d244abcb32a88b1249e99ba ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 39m 12s |
This change is to fix the openvswitch package missing
issue during configure ovs dpdk for pre provisioned
EDPM nodes.
We already have ovs packages installation, ovs services
are enabled and running part in configure-network which
is common for all deployment.
To avoid issue in configure ovs dpdk, we are adding only
openvswitch package installation part and not using
existing edpm_ovs install.yml task to avoid complete
redundat like ovs services configuration, enable
and running part.