Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch coverage to coveralls statistics #4444

Closed
tomato42 opened this issue Sep 29, 2017 · 5 comments
Closed

Add branch coverage to coveralls statistics #4444

tomato42 opened this issue Sep 29, 2017 · 5 comments

Comments

@tomato42
Copy link
Contributor

Coveralls.io recently gained support for measuring not only line coverage but also branch coverage: lemurheavy/coveralls-public#31 (comment)

I'd like to see it reported openssl builds

@richsalz
Copy link
Contributor

And also as you commented in another PR, we should try to make "failures" ignore anything less than .5% or such.

@levitte
Copy link
Member

levitte commented Sep 30, 2017

Unless I'm mistaken, coveralls.io has simply started to show branch coverage, hasn't it? The rest depends entirely on what code we actually run in our tests, i.e. do we actually run all branches everywhere? (I doubt it, there are lots of places where we don't deliberately try to cause faults, for example)

@levitte
Copy link
Member

levitte commented Sep 30, 2017

Or do you have to switch something on to display branch coverage? I've looked around a bit, but can't find such a switch. If there is one, someone please point it out, thank you.

@tomato42
Copy link
Contributor Author

gcov needs to be told to collect branch coverage - that's options -b and -c

coveralls needs to be told to display them - that's in project Settings → Badge and Token → Branch Coverage checkbox near "Include in Aggregate %"

after both of those things are done, a new run should have two new columns in the source file listing - branch hits and branch misses

@levitte
Copy link
Member

levitte commented Sep 30, 2017

Ok, thanks for the info. I've just changed the settings at Coveralls, and pushed a PR to add the flags in our .travis.yml

levitte added a commit to levitte/openssl that referenced this issue Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants